Details

Implemented deeplink on the web app that will show a popup to the user asking if they want to open the desktop app (if the desktop app is installed).
The deeplink code will trigger the popup if the user opens up the web app in any of the following routes:

/concierge/*
/statements/*
/partners/plaid/oauth_ios/
/enable-payments/*
/iou/*
/bank-account/*
/v/*
/details/*
/setpassword/*
/settings/*
/r/*

Fixed Issues

$ #10893
PROPOSAL: #10893 (comment)

Tests

1. Navigate to Expensify's home page on MacOS
2. Make sure the deeplink popup does NOT show
3. Navigate to any of the screens listed above, like the settings page
4. Now you should see a screen saying Launching Expensify and the deeplink popup above it.
5. If you click to open Expensify it should open the desktop app and take you straight to the given page you are (like the settings page we used in the example above).
6. If you close the popup and press to "open this link in your browser" if should take you straight to that same page and the "Launching Expensify" screen should be gone.
7. Please notice that if you're testing in Safari there's a small bug that was already discussed here. Safari has a known bug where the deeplink "check" (the "Launching Expenfify" screen) will only work/show if you move your mouse while the website is loading). That's a minor bug that was previously discussed and that does not affect the deeplink feature, as it will launch the app if you have it installed.

• Verify that no errors appear in the JS console

Offline tests

1. Navigate to Expensify's home page on MacOS
2. Make sure the deeplink popup does NOT show
3. Navigate to any of the screens listed above, like the settings page
4. Now you should see a screen saying Launching Expensify and the deeplink popup above it.
5. If you click to open Expensify it should open the desktop app and take you straight to the given page you are (like the settings page we used in the example above).
6. If you close the popup and press to "open this link in your browser" if should take you straight to that same page and the "Launching Expensify" screen should be gone.
7. Please notice that if you're testing in Safari there's a small bug that was already discussed here. Safari has a known bug where the deeplink "check" (the "Launching Expenfify" screen) will only work/show if you move your mouse while the website is loading). That's a minor bug that was previously discussed and that does not affect the deeplink feature, as it will launch the app if you have it installed.

QA Steps

1. Navigate to Expensify's home page on MacOS
2. Make sure the deeplink popup does NOT show
3. Navigate to any of the screens listed above, like the settings page
4. Now you should see a screen saying Launching Expensify and the deeplink popup above it.
5. If you click to open Expensify it should open the desktop app and take you straight to the given page you are (like the settings page we used in the example above).
6. If you close the popup and press to "open this link in your browser" if should take you straight to that same page and the "Launching Expensify" screen should be gone.
7. Please notice that if you're testing in Safari there's a small bug that was already discussed here. Safari has a known bug where the deeplink "check" (the "Launching Expenfify" screen) will only work/show if you move your mouse while the website is loading). That's a minor bug that was previously discussed and that does not affect the deeplink feature, as it will launch the app if you have it installed.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Chrome

Safari

Microsoft Edge

Firefox

Opera